linode / linode-blockstorage-csi-driver

Container Storage Interface (CSI) Driver for Linode Block Storage
Apache License 2.0
68 stars 57 forks source link

[Feat] Node Server Metrics Implementation #278

Closed prajwalvathreya closed 1 month ago

prajwalvathreya commented 1 month ago

This PR is to get the metrics of the functions performed by the node server. The functions for which the metrics are implemented are:

NodePublishVolume NodeUnpublishVolume NodeStageVolume NodeUnstageVolume NodeExpandVolume

General:

Pull Request Guidelines:

  1. [x] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [x] Are you addressing a single feature in this PR?
  4. [ ] Are your commits atomic, addressing one change per commit?
  5. [ ] Are you following the conventions of the language?
  6. [ ] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [ ] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 55.05618% with 40 lines in your changes missing coverage. Please review.

Project coverage is 75.31%. Comparing base (0b18622) to head (9f86018). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/driver/nodeserver.go 29.72% 26 Missing :warning:
internal/driver/server.go 67.74% 8 Missing and 2 partials :warning:
main.go 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #278 +/- ## ========================================== - Coverage 76.33% 75.31% -1.03% ========================================== Files 21 22 +1 Lines 1644 1730 +86 ========================================== + Hits 1255 1303 +48 - Misses 289 325 +36 - Partials 100 102 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.