Closed komer3 closed 2 weeks ago
Attention: Patch coverage is 50.00000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 74.83%. Comparing base (
12e5659
) to head (b40379a
). Report is 3 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
internal/driver/controllerserver_helper.go | 33.33% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@srust The region mismatch error serves as a critical validation check (sort of double checking). This issue typically surfaces only in specific multi-region scenarios where cluster configuration may be incomplete.
This issue occurs when:
Consider this setup:
In this case, the CSI driver defaults to creating the volume in ORD (fallback region) instead of the intended IAD region, triggering the mismatch error.
Note: This error should only manifest when utilizing the CSI driver's multi-region capabilities.
This error should not be triggered with how we currently use and deploy CSI driver. Replacing the use of VolumeContext should make this check more reliable and not trigger anymore unless in very specific cases such as the one I mentioned above.
Hope that answers your question! :)
volumeContext[VolumeTopologyRegion] was not a reliable source to get volumes region. We saw multiple instances where this was returning an empty string which was causing the region mismatch failure. Switching to just use volume obj returned by API to validate is a better and more robust approach since LinodeVolume Obj returned by the API will always have the correct region field.
General:
Pull Request Guidelines: