linode / linode-blockstorage-csi-driver

Container Storage Interface (CSI) Driver for Linode Block Storage
Apache License 2.0
68 stars 56 forks source link

fix: right volume_condition message when healthy #311

Open guilhem opened 3 days ago

guilhem commented 3 days ago

This pull request includes changes to the nodeGetVolumeStats function in the internal/driver/nodeserver_all.go file to improve error handling and volume condition reporting. The most important changes include refactoring the error handling logic and introducing a volumeCondition variable to manage the state of the volume.

Improvements to error handling and volume condition reporting:

General:

Pull Request Guidelines:

  1. [ ] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [ ] Are you addressing a single feature in this PR?
  4. [ ] Are your commits atomic, addressing one change per commit?
  5. [ ] Are you following the conventions of the language?
  6. [ ] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [ ] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue
codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 74.51%. Comparing base (4ecf4c4) to head (b20ea31).

Files with missing lines Patch % Lines
internal/driver/nodeserver_all.go 0.00% 20 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #311 +/- ## ========================================== - Coverage 74.79% 74.51% -0.28% ========================================== Files 22 22 Lines 2396 2405 +9 ========================================== Hits 1792 1792 - Misses 499 508 +9 Partials 105 105 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: