search

linode / linode-blockstorage-csi-driver

Container Storage Interface (CSI) Driver for Linode Block Storage
Apache License 2.0
66 stars 55 forks source link

Adding Helm Chart #90

Closed komer3 closed 1 year ago

komer3 commented 1 year ago

Reasoning:

Adding a helm chart for this component to bring the CSI driver in line with the industry standard of using helm charts to deploy on Kubernetes. This will simplify the deployment process for users. Helm charts are also easier to maintain and understand for developers.

This chart was created using the concatenated yaml file found here: https://raw.githubusercontent.com/linode/linode-blockstorage-csi-driver/master/pkg/linode-bs/deploy/releases/linode-blockstorage-csi-driver.yaml

General:

Pull Request Guidelines:

  1. [x] Does your submission pass tests?
  2. [ ] Have you added tests?
  3. [x] Are you addressing a single feature in this PR?
  4. [ ] Are your commits atomic, addressing one change per commit?
  5. [x] Are you following the conventions of the language?
  6. [ ] Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. [x] Have you explained your rationale for why this feature is needed?
  8. [ ] Have you linked your PR to an open issue
AshleyDumaine commented 1 year ago

Thanks for the PR! Some minor comments above, also looks like some of the files are missing newlines at the end, can we get those added in? https://github.com/linode/linode-cloud-controller-manager/pull/112#discussion_r1089090261

rahulait commented 1 year ago

Just few minor comments. Otherwise, the PR looks good to me.

AshleyDumaine commented 1 year ago

Changes LGTM, can you fixup/squash the extra commits? Should be good to go after that. Thanks!