linode / linode-cli

The official Linode command line interface.
https://linode.com
BSD 3-Clause "New" or "Revised" License
375 stars 135 forks source link

Add lke tests #641

Closed vshanthe closed 2 weeks ago

vshanthe commented 3 weeks ago

📝 Description

Added test for lke as part of test coverage

✔️ How to Test

make MODULE=lke testint

How do I run the relevant unit/integration tests?

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

vshanthe commented 2 weeks ago

I'm seeing a test failure when running the integration tests:

============================================================================ FAILURES ============================================================================
_________________________________________________________________________ test_view_pool _________________________________________________________________________

get_cluster_id = '228945', get_node_pool_id = '332694'

    def test_view_pool(get_cluster_id, get_node_pool_id):
        cluster_id = get_cluster_id
        node_pool_id = get_node_pool_id
        res = (
            exec_test_command(
                BASE_CMD
                + ["pool-view", cluster_id, node_pool_id, "--text", "--delimiter=,"]
            )
            .stdout.decode()
            .rstrip()
        )
        lines = res.splitlines()
        headers = ["type", "labels.value"]
>       assert_headers_in_lines(headers, lines)

tests/integration/lke/test_clusters.py:220: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

headers = ['type', 'labels.value'], lines = ['autoscaler.enabled,autoscaler.max,autoscaler.min,type,count,id,tags', 'False,1,1,g6-standard-1,1,332694,']

    def assert_headers_in_lines(headers, lines):
        for header in headers:
>           assert header in lines[0]
E           AssertionError

tests/integration/helpers.py:147: AssertionError
==================================================================== short test summary info =====================================================================
FAILED tests/integration/lke/test_clusters.py::test_view_pool - AssertionError

Do you see this failure locally too?

I'm not getting this error , will check it once Screenshot 2024-09-16 at 1 08 14 PM

ezilber-akamai commented 2 weeks ago

I'm seeing a test failure when running the integration tests:

============================================================================ FAILURES ============================================================================
_________________________________________________________________________ test_view_pool _________________________________________________________________________

get_cluster_id = '228945', get_node_pool_id = '332694'

    def test_view_pool(get_cluster_id, get_node_pool_id):
        cluster_id = get_cluster_id
        node_pool_id = get_node_pool_id
        res = (
            exec_test_command(
                BASE_CMD
                + ["pool-view", cluster_id, node_pool_id, "--text", "--delimiter=,"]
            )
            .stdout.decode()
            .rstrip()
        )
        lines = res.splitlines()
        headers = ["type", "labels.value"]
>       assert_headers_in_lines(headers, lines)

tests/integration/lke/test_clusters.py:220: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

headers = ['type', 'labels.value'], lines = ['autoscaler.enabled,autoscaler.max,autoscaler.min,type,count,id,tags', 'False,1,1,g6-standard-1,1,332694,']

    def assert_headers_in_lines(headers, lines):
        for header in headers:
>           assert header in lines[0]
E           AssertionError

tests/integration/helpers.py:147: AssertionError
==================================================================== short test summary info =====================================================================
FAILED tests/integration/lke/test_clusters.py::test_view_pool - AssertionError

Do you see this failure locally too?

I'm not getting this error , will check it once Screenshot 2024-09-16 at 1 08 14 PM

Interesting, it seems to be failing with this error consistently on my end. Perhaps it is something with my account?

lgarber-akamai commented 2 weeks ago

Interesting, it seems to be failing with this error consistently on my end. Perhaps it is something with my account?

Weirdly I'm not running into this issue on my end either 🤔

lgarber-akamai commented 2 weeks ago

@ezilber-akamai Could you try running make install and re-running the tests? It seems like your local install doesn't have all the output table columns for some reason

ezilber-akamai commented 2 weeks ago

@ezilber-akamai Could you try running make install and re-running the tests? It seems like your local install doesn't have all the output table columns for some reason

Yeah that did the trick. Thanks!