search

linode / linode_api4-python

Official Python bindings for the Linode API
https://linode-api4.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
135 stars 75 forks source link

Project: Image Services Gen2 #445

Closed yec-akamai closed 1 month ago

yec-akamai commented 1 month ago

📝 Description

Project Image Gen2 LA

make testint TEST_SUITE=linode_client
make testint TEST_SUITE=image
ezilber-akamai commented 1 month ago

I'm also running into a 404 when running make testint TEST_SUITE=image but this is likely because the test isn't being run in the correct region. Is there some additional setup I need to do to run the test against the right region?

yec-akamai commented 1 month ago

I'm also running into a 404 when running make testint TEST_SUITE=image but this is likely because the test isn't being run in the correct region. Is there some additional setup I need to do to run the test against the right region?

Interesting, I've hardcoded the region to be us-east and it should work. Do you have the customer tag we mentioned in the thread?

lgarber-akamai commented 1 month ago

@ezilber-akamai For the account settings test, it looks like the regex is looking for 'network_helper':True or just False instead of 'network_helper': True or 'network_helper': False. I'm guessing this is causing a failure on your end since your account doesn't seem to have any disabled settings.

I think the corrected pattern would look like this:

'network_helper':\s*(True|False)

If we don't want to include that fix in this PR since it's out of scope, it might be ticket-worthy 🙂

yec-akamai commented 1 month ago

If we don't want to include that fix in this PR since it's out of sc

Good point! I included this fix in the PR. Also I changed a bit the get random region function to make sure we only get core site for testing. Some of the functions are not available in non-core sites.

ykim-1 commented 1 month ago

LGTM tests pass locally