search

linode / linodego

Go client for Linode REST v4 API
MIT License
138 stars 81 forks source link

integration tests #531

Closed vshanthe closed 3 months ago

vshanthe commented 4 months ago

📝 Description

Added Integration Test Account modules What does this PR do and why is this change necessary? Test coverage

✔️ How to Test

make testint

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

ykim-akamai commented 4 months ago

LGTM mostly, but I had some failures running on my personal test account in record fixture mode. I think it might be better to make these assertions more flexible

    account_settings_test.go:24: Expected Managed to be true, got false
--- FAIL: TestAccountSettings_Get (0.46s)
=== RUN   TestAccountSettings_Update
    account_settings_test.go:52: Error updating Account Settings, expected struct, got error [400] [longview_subscription] longview_subscription editing at this location is no longer available. Please use the /longview/plan endpoint instead.
--- FAIL: TestAccountSettings_Update (0.13s)
=== RUN   TestInvoice_Get
    account_invoice_test.go:28: Error getting Invoice, expected struct, got error [404] Not found
--- FAIL: TestInvoice_Get (0.19s)
=== RUN   TestInvoiceItems_List
    account_invoice_test.go:50: Error getting Invoice Items, expected struct, got error [404] Not found
--- FAIL: TestInvoiceItems_List (0.13s)
vshanthe commented 4 months ago

LGTM mostly, but I had some failures running on my personal test account in record fixture mode. I think it might be better to make these assertions more flexible

    account_settings_test.go:24: Expected Managed to be true, got false
--- FAIL: TestAccountSettings_Get (0.46s)
=== RUN   TestAccountSettings_Update
    account_settings_test.go:52: Error updating Account Settings, expected struct, got error [400] [longview_subscription] longview_subscription editing at this location is no longer available. Please use the /longview/plan endpoint instead.
--- FAIL: TestAccountSettings_Update (0.13s)
=== RUN   TestInvoice_Get
    account_invoice_test.go:28: Error getting Invoice, expected struct, got error [404] Not found
--- FAIL: TestInvoice_Get (0.19s)
=== RUN   TestInvoiceItems_List
    account_invoice_test.go:50: Error getting Invoice Items, expected struct, got error [404] Not found
--- FAIL: TestInvoiceItems_List (0.13s)

I have test on my personal account and GA account as well, passing both cases === RUN TestAccountSettings_Get --- PASS: TestAccountSettings_Get (0.00s) === RUN TestAccountSettings_Update --- PASS: TestAccountSettings_Update (0.00s)

lgarber-akamai commented 3 months ago

Looks like you'll need a quick make tidy to fix the failing CI

vshanthe commented 3 months ago

closing this PR and raising the new PR due the base branch requires all commits to be signed resolving it creating too many conflicts raised new PR - https://github.com/linode/linodego/pull/561