linode / manager

Akamai's Cloud Manager is an open-source, single-page application designed as the primary frontend interface for interacting with the Linode API. It is entrusted by hundreds of thousands of customers with the management of their Linode services.
https://cloud.linode.com
Apache License 2.0
690 stars 361 forks source link

fix: [M3-8158] - Render the correct Avatar icon for `ACTIONS_WITHOUT_USERNAMES` #10923

Closed mjac0bs closed 1 month ago

mjac0bs commented 1 month ago

Description ๐Ÿ“

One more bug fix...

There are a very small number of events that we consider ACTIONS_WITHOUT_USERNAMES. Some of these actions have no username, and other we want to override the username with Linode - we have a util called getEventUsername to do this for us.

We weren't making use of the username from the util correctly in this component, which we assign at L36.

Without using this util, if a username existed (as it does for entity_transfer_create events), we were rendering the wrong initial in the avatar component. Since this is an 'action without username', we want the username to be Linode and to render the Akamai logo as the avatar.

We were already using this util in the EventRow component on Event Landing page; the bug was just in the Notification Center event.

~No changeset, didn't make it to prod.~ Adding a changeset because this actually was an existing bug in prod, but becomes more obvious once we start using the initialed avatars.

Changes ๐Ÿ”„

Target release date ๐Ÿ—“๏ธ

9/16/24

Preview ๐Ÿ“ท

Before After
Screenshot 2024-09-11 at 12 35 04โ€ฏPM Screenshot 2024-09-11 at 12 34 19โ€ฏPM
Prod: image Screenshot 2024-09-11 at 1 25 00โ€ฏPM

How to test ๐Ÿงช

Prerequisites

(How to setup test environment)

Reproduction steps

(How to reproduce the issue, if applicable)

Verification steps

(How to verify changes)

As an Author I have considered ๐Ÿค”

Check all that apply

github-actions[bot] commented 1 month ago

Coverage Report: โœ…
Base Coverage: 86.64%
Current Coverage: 86.64%