linode / manager

Akamai's Cloud Manager is an open-source, single-page application designed as the primary frontend interface for interacting with the Linode API. It is entrusted by hundreds of thousands of customers with the management of their Linode services.
https://cloud.linode.com
Apache License 2.0
687 stars 353 forks source link

change: Use loading icon to indicate tax id is being verified #10928

Closed jaalah-akamai closed 6 days ago

jaalah-akamai commented 1 week ago

Description ๐Ÿ“

We need to verify the tax id before any of the events tax_id_valid or tax_id_invalid are fired off. This new icon provides a better UX.

See for more details: https://github.com/linode/manager/pull/10558

Changes ๐Ÿ”„

Target release date ๐Ÿ—“๏ธ

9/16

Preview ๐Ÿ“ท

Include a screenshot or screen recording of the change

https://github.com/user-attachments/assets/e2a9c20d-54ae-446b-a853-e4148c41973b

Before After
Screenshot 2024-07-08 at 9 59 11โ€ฏAM Screenshot 2024-09-12 at 3 08 30โ€ฏPM

How to test ๐Ÿงช

Verification steps

Just observe that removing code does not break anything within the file itself.

As an Author I have considered ๐Ÿค”

Check all that apply

github-actions[bot] commented 1 week ago

Coverage Report: โœ…
Base Coverage: 86.64%
Current Coverage: 86.64%

jaalah-akamai commented 1 week ago

Should we also clean up the tax id types/events/etc introduced in #10558?

We'll still need those ๐Ÿ‘

jaalah-akamai commented 1 week ago

Does the API just clear the account's tax_id field if it is invalid? Wondering if it's bad that were just cleaning user data

It's not great and I made this known. There's a couple options we can do on the frontend to improve the experience while not displaying invalid tax ids on invoices. This will be coming soon, but until then we had to remove this one aspect since the requirements changed slightly and it was no longer accurate

bnussman-akamai commented 1 week ago

Understood! Thanks @jaalah-akamai