test: [M3-8565] - Add unit tests for rest of NodeBalancers package

coliu-akamai commented 3 days ago

Description 📝

Adds unit tests for the rest of NodeBalancers package to improve test coverage and confirm things render as expected

Target release date 🗓️

n/a

How to test 🧪

yarn test NodeBalancers - confirm all tests pass

As an Author I have considered 🤔

Check all that apply

[ ] 👀 Doing a self review
[ ] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[ ] ➕ Adding a changeset
[x] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[ ] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿ Providing accessibility support

github-actions[bot] commented 3 days ago

Coverage Report: ✅
Base Coverage: 86.64%
Current Coverage: 86.8%

coliu-akamai commented 3 days ago

This is weird... nodebalancers/nodebalancers-create-in-complex-form.spec.ts passes locally when I use yarn cy:debug, but not when I run it directly... gonna look into this a bit more!

probably something to do with this privacy policy/EU check - maybe sometimes a region from the EU is chosen which triggers this check? cc @jdamore-linode (sorry for the blurry photo, just screenshotted it from the outputted video)

coliu-akamai commented 1 day ago

created M3-8600 to look into the test flake for nodebalancers/nodebalancers-create-in-complex-form.spec.ts some more, separate from this pr. Will be merging this one in

linode / manager