fix: [M3-8589] - Flickering on the user profile page when updating the currently signed in user's username - Githubissues

linode / manager

Akamai's Cloud Manager is an open-source, single-page application designed as the primary frontend interface for interacting with the Linode API. It is entrusted by hundreds of thousands of customers with the management of their Linode services.

https://cloud.linode.com

Apache License 2.0

690 stars 361 forks source link

fix: [M3-8589] - Flickering on the user profile page when updating the currently signed in user's username #10947

Closed bnussman-akamai closed 1 month ago

bnussman-akamai commented 1 month ago

Description 📝

Updates our cache updating logic on the useUpdateUserMutation hook to manually update the profile cache rather than invalidating it 🔧
This fixes 🔧 the bug :bug: caught by @mjac0bs where the page would exhibit some flickering on the Delete button and Email fields when updating the username of the currently signed in user

Preview 📷

Before	After

How to test 🧪

Prerequisites

Check out this PR or use the preview link
Go to the user profile of the currency signed in user
- In my case, this is http://localhost:3000/account/users/banks
Try updating the username
Verify there is no flickering at all

As an Author I have considered 🤔

[ ] 👀 Doing a self review
[ ] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[x] ➕ Adding a changeset
[ ] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[ ] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿ Providing accessibility support

github-actions[bot] commented 1 month ago

Coverage Report: ✅
Base Coverage: 86.7%
Current Coverage: 86.7%