linode / manager

Akamai's Cloud Manager is an open-source, single-page application designed as the primary frontend interface for interacting with the Linode API. It is entrusted by hundreds of thousands of customers with the management of their Linode services.
https://cloud.linode.com
Apache License 2.0
690 stars 361 forks source link

feat: [UIE-8009] - DBaaS enhancements Backups #10961

Closed mpolotsk-akamai closed 1 month ago

mpolotsk-akamai commented 1 month ago

Description 📝

DBaaS 2.0 Backups

Changes 🔄

Target release date 🗓️

9/16/24

Preview 📷

Before After
Screenshot 2024-09-18 at 3 09 52 PM Screenshot 2024-09-19 at 8 46 30 PM
Screenshot 2024-09-19 at 8 44 28 PM
Screenshot 2024-09-18 at 3 08 13 PM Screenshot 2024-09-18 at 3 08 00 PM

How to test 🧪

Note: To test all beta features, beta must be enabled, and the user must have the "Managed Databases Beta" account capability.

Prerequisites

(How to setup test environment)

Enable DatabaseV2Beta flag

Verification steps

(How to verify changes)

  1. Navigate to the Databases section.
  2. Choose the Database Cluster.
  3. Go to the Backups tab.
  4. Select a date from the DatePicker.
  5. Choose the time from the TimePicker.
  6. Click the 'Restore' button.
  7. A popup will appear with the Database Label and the chosen date and time.
  8. Click the 'Restore' button in the popup dialog.
  9. You will be redirected to the Summary tab.

As an Author I have considered 🤔

Check all that apply

github-actions[bot] commented 1 month ago

Coverage Report:
Base Coverage: 86.94%
Current Coverage: 86.94%

mjac0bs commented 1 month ago

I'll give this a final approval once the date and time picker are swapped out and Alban's feedback is addressed, but thank you for making initial changes - this is looking good and clean overall!

As far as test failures:

mpolotsk-akamai commented 1 month ago

@mjac0bs , @abailly-akamai thank you for the review. I’ve updated the time picker and made all the necessary changes.

abailly-akamai commented 1 month ago

@mpolotsk-akamai @mjac0bs @gitkcosby I believe we agreed on using a day select as well and removing this version of the calendar waiting for the real component. This is the request that was agreed upon. Pretty much

Screenshot 2024-09-19 at 11 23 17

except it would be a date field on the left

mpolotsk-akamai commented 1 month ago

@abailly-akamai , based on our discussion with @gitkcosby , @corya-akamai we’ll proceed with the MUI Calendar and a standard drop down for selecting a time.

mjac0bs commented 1 month ago

except it would be a date field on the left

Right. @mpolotsk-akamai, @mpolotsk-akamai, @corya-akamai - I think @abailly-akamai's recommendation of <Texfield type="date"> is the way to go here, as it will get you the same data and avoid introducing the new calendar component just yet.

abailly-akamai commented 1 month ago

@mjac0bs I cleared it with @gitkcosby - we'll keep it for DBaaS and we'll do as quick a follow up as possible to replace this instance soon, hoping no more pop up. If we catch other instances in other PRs we can prevent spread.

I am reviewing the e2e failures now but this should be good to go otherwise

mjac0bs commented 1 month ago

Note that the update-database spec failure will be fixed by https://github.com/linode/manager/pull/10975.