Closed mpolotsk-akamai closed 1 month ago
Coverage Report: ✅
Base Coverage: 86.94%
Current Coverage: 86.94%
I'll give this a final approval once the date and time picker are swapped out and Alban's feedback is addressed, but thank you for making initial changes - this is looking good and clean overall!
As far as test failures:
The unit test failure is legit and is a quick fix to include the space betweenTime
and (UTC)
.
I noticed a Cypress failure on the update-databases.spec.ts
that I hadn't seen recently. But from running that test locally and watching it, it only seems to be touching the Settings page, and I don't see any interaction with the Backups tab changes made here. Seems like it may have been flake - worth keeping an eye on, though.
@mjac0bs , @abailly-akamai thank you for the review. I’ve updated the time picker and made all the necessary changes.
@mpolotsk-akamai @mjac0bs @gitkcosby I believe we agreed on using a day select as well and removing this version of the calendar waiting for the real component. This is the request that was agreed upon. Pretty much
except it would be a date field on the left
@abailly-akamai , based on our discussion with @gitkcosby , @corya-akamai we’ll proceed with the MUI Calendar and a standard drop down for selecting a time.
except it would be a date field on the left
Right. @mpolotsk-akamai, @mpolotsk-akamai, @corya-akamai - I think @abailly-akamai's recommendation of <Texfield type="date">
is the way to go here, as it will get you the same data and avoid introducing the new calendar component just yet.
@mjac0bs I cleared it with @gitkcosby - we'll keep it for DBaaS and we'll do as quick a follow up as possible to replace this instance soon, hoping no more pop up. If we catch other instances in other PRs we can prevent spread.
I am reviewing the e2e failures now but this should be good to go otherwise
Note that the update-database
spec failure will be fixed by https://github.com/linode/manager/pull/10975.
Description 📝
DBaaS 2.0 Backups
Changes 🔄
Target release date 🗓️
9/16/24
Preview 📷
How to test 🧪
Note: To test all beta features, beta must be enabled, and the user must have the "Managed Databases Beta" account capability.
Prerequisites
(How to setup test environment)
Enable DatabaseV2Beta flag
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply