linode / manager

Akamai's Cloud Manager is an open-source, single-page application designed as the primary frontend interface for interacting with the Linode API. It is entrusted by hundreds of thousands of customers with the management of their Linode services.
https://cloud.linode.com
Apache License 2.0
690 stars 361 forks source link

fix: [M3-8508] - Cancel Button Not Functioning in Delete Node Balancer Configuration Dialog #10962

Closed cpathipa closed 1 month ago

cpathipa commented 1 month ago

Description πŸ“

This PR fix the issue Cancel Button not functioning inDelete Node Balancer Configuration Dialog.

Target release date πŸ—“οΈ

9/30

Preview

https://github.com/user-attachments/assets/38ebd46f-3cf3-499a-9e17-f6fa5f836aa7

How to test πŸ§ͺ

Verification steps

(How to verify changes)

Check all that apply

github-actions[bot] commented 1 month ago

Coverage Report: βœ…
Base Coverage: 87.13%
Current Coverage: 87.13%

cpathipa commented 1 month ago

@cpathipa can you give more context to why the cancel button wasn't working before?

@hana-linode I believe the issue is due to handler not binded to the context, where click action is not picking up earlier. Any thoughts in handling this in a better way? one of reason for abstraction is NodeBalancerConfigurations file its self is too large and added the tests to make sure handlers are called while using ActionsPanel in this component and specific to the defect.