linode / manager

Akamai's Cloud Manager is an open-source, single-page application designed as the primary frontend interface for interacting with the Linode API. It is entrusted by hundreds of thousands of customers with the management of their Linode services.
https://cloud.linode.com
Apache License 2.0
691 stars 361 forks source link

test: [LKEAPIFW-529] - Update LKE create tests for ACL defaults change #11237

Closed jdamore-linode closed 5 days ago

jdamore-linode commented 5 days ago

Description ๐Ÿ“

Quick fix to a few tests in lke-create.spec.ts to coincide with the change made by #11234, which disabled the ACL toggle by default on the LKE create page.

I don't believe any changeset is needed for this PR since it's a quick follow-up to #11234, which hasn't been released yet.

Changes ๐Ÿ”„

Target release date ๐Ÿ—“๏ธ

This is meant for v1.32.0 (2024-11-12), but it's not absolutely crucial since there's no underlying bug and we have a good understanding of why the tests are failing. Still, it would be nice to get this merged for the release if we can

How to test ๐Ÿงช

This test has a 100% failure rate. You can reproduce by checking out the release-v1.132.0 test, building Cloud, and running the lke-create.spec.ts tests, and confirm that this fixes it by observing the test results in CI.

As an Author I have considered ๐Ÿค”

Check all that apply

github-actions[bot] commented 5 days ago

Coverage Report: โœ…
Base Coverage: 87.46%
Current Coverage: 87.46%

linode-gh-bot commented 5 days ago

Cloud Manager UI test results

:tada: 445 passing tests on test run #4 โ†—๏ธŽ

:x: Failing:white_check_mark: Passing:arrow_right_hook: Skipped:clock1: Duration
0 Failing445 Passing2 Skipped84m 33s