upcoming: [DI-21119] - Handle jwe token limit in ACLP UI and Bug fix for resources component

linode / manager

Akamai's Cloud Manager is an open-source, single-page application designed as the primary frontend interface for interacting with the Linode API. It is entrusted by hundreds of thousands of customers with the management of their Linode services.

https://cloud.linode.com

Apache License 2.0

700 stars 363 forks source link

upcoming: [DI-21119] - Handle jwe token limit in ACLP UI and Bug fix for resources component #11309

Closed ankita-akamai closed 3 days ago

ankita-akamai commented 1 week ago

Description 📝

Handled jwe token limit in ACLP UI and Bug fix for resources component.

Changes 🔄

List any change(s) relevant to the reviewer.

JWE token will only be created for selected resources/database clusters. It was earlier created for all the available resources of selected service type.
Resources/Database clusters autocomplete has a bug fix - When these three are equal => 1. available resources/clusters 2. selected resources/clusters 3. max resource selection limit, select/deselect all will work as expected. Earlier, in this edge case, deselect all got disabled after maximum resources selection.

Target release date 🗓️

2-Dec-2024

Preview 📷

Before	After

How to test 🧪

Verification steps

(How to verify changes)

Navigate to monitor tab.
Select all the filters.
Open networks tab, see the token call fired, observe the payload passed, it has selected resources/clusters' ids.

As an Author, I have considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

[x] I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

[x] All unit tests are passing
[x] TypeScript compilation succeeded without errors
[x] Code passes all linting rules

github-actions[bot] commented 5 days ago

Coverage Report: ✅
Base Coverage: 86.93%
Current Coverage: 86.93%

ankita-akamai commented 4 days ago

@bnussman-akamai is there any additional feedback for this pr or it is good for approval?

ankita-akamai commented 3 days ago

Changes look good! A small nit for the changeset

@harsh-akamai done!

linode-gh-bot commented 3 days ago

Cloud Manager UI test results

:small_red_triangle: 4 failing tests on test run #3 ↗︎

:x: Failing	:white_check_mark: Passing	:arrow_right_hook: Skipped	:clock1: Duration
`4 Failing`	`451 Passing`	`2 Skipped`	`101m 50s`

Details

Failing Tests
	Spec	Test
:x:	`machine-image-upload.spec.ts`	machine image » uploads machine image, mock finish event
:x:	`machine-image-upload.spec.ts`	machine image » uploads machine image, mock upload canceled failed event
:x:	`machine-image-upload.spec.ts`	machine image » uploads machine image, mock failed to decompress failed event
:x:	`machine-image-upload.spec.ts`	machine image » uploads machine image, mock expired upload event

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts"