refactor: [M3-8709] – Migrate `Autocomplete` (and `List` and `ListItem`) to `ui` package

dwiley-akamai commented 1 week ago

Description 📝

Migrate Autocomplete (and List and ListItem) to ui package.

Changes 🔄

Migrate Autocomplete to ui package
Migrate List and ListItem to ui package
Refactor Autocomplete.stories.tsx to not use linodeFactory (avoid having manager as a dependency of ui package)

Target release date 🗓️

12/10/24

How to test 🧪

Verification steps

All tests should pass
There should be no regressions observed in Cloud
Autocomplete story in Storybook should be in good shape

As an Author, I have considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

[X] I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

[X] All unit tests are passing
[X] TypeScript compilation succeeded without errors
[X] Code passes all linting rules

github-actions[bot] commented 1 week ago

Coverage Report: ❌
Base Coverage: 86.95%
Current Coverage: 86.86%

hana-akamai commented 1 week ago

Looks like there's some merge conflicts that need to be resolved

linode-gh-bot commented 2 hours ago

Cloud Manager UI test results

:tada: 462 passing tests on test run #5 ↗︎

:x: Failing	:white_check_mark: Passing	:arrow_right_hook: Skipped	:clock1: Duration
`0 Failing`	`462 Passing`	`2 Skipped`	`104m 45s`

cypress[bot] commented 1 hour ago

Cloud Manager E2E Run #6905

Run Properties: Failed #6905 • 5aeb6509b2: refactor: [M3-8709] – Migrate `Autocomplete` (and `List` and `ListItem`) to `ui`...

Project	`Cloud Manager E2E`
Branch Review	`develop`
Run status	`Failed #6905`
Run duration	`30m 20s`
Commit	5aeb6509b2: refactor: [M3-8709] – Migrate `Autocomplete` (and `List` and `ListItem`) to `ui`...
Committer	`Dajahi Wiley`
View all properties for this run ↗︎

Test results
Failures	`1`
Flaky	`3`
Pending	`2`
Skipped	`0`
Passing	`464`
View all changes introduced in this branch ↗︎

Tests for review

cypress/e2e/core/linodes/rebuild-linode.spec.ts • 1 failed test

View Output Video

Test		Artifacts
rebuild linode > rebuilds a linode from Account StackScript		`Screenshots` `Video`

kubernetes/lke-create.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
LKE Cluster Creation > can create an LKE cluster		`Screenshots` `Video`

firewalls/migrate-linode-with-firewall.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
Migrate Linode With Firewall > migrates linode with firewall - real data		`Screenshots` `Video`

billing/google-pay.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
Google Pay > adds google pay method		`Screenshots` `Video`

linode / manager