fix: [M3-8947] - Remove recently added camelCase rule

linode / manager

Akamai's Cloud Manager is an open-source, single-page application designed as the primary frontend interface for interacting with the Linode API. It is entrusted by hundreds of thousands of customers with the management of their Linode services.

https://cloud.linode.com

Apache License 2.0

700 stars 363 forks source link

fix: [M3-8947] - Remove recently added camelCase rule #11330

Closed pmakode-akamai closed 3 days ago

pmakode-akamai commented 4 days ago

Description 📝

Currently, our camelCase ESLint rule is causing thousands of warnings due to APIv4 property names in our codebase. We need a more targeted approach. We'll implement a more targeted approach in the upcoming PR.

Changes 🔄

List any change(s) relevant to the reviewer.

Remove recently added camelCase rule

Target release date 🗓️

N/A

How to test 🧪

Ensure everything builds properly
Ensure no related warnings due to APIv4 property names in our codebase

As an Author, I have considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

[x] I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

[x] All unit tests are passing
[x] TypeScript compilation succeeded without errors
[x] Code passes all linting rules

github-actions[bot] commented 3 days ago

Coverage Report: ✅
Base Coverage: 86.93%
Current Coverage: 86.93%

linode-gh-bot commented 3 days ago

Cloud Manager UI test results

:tada: 455 passing tests on test run #4 ↗︎

:x: Failing	:white_check_mark: Passing	:arrow_right_hook: Skipped	:clock1: Duration
`0 Failing`	`455 Passing`	`2 Skipped`	`100m 34s`

cypress[bot] commented 3 days ago

Cloud Manager E2E Run #6891

Run Properties: Passed #6891 • 6a078a9beb: fix: [M3-8947] - Remove recently added camelCase rule (#11330)

Project	`Cloud Manager E2E`
Branch Review	`develop`
Run status	`Passed #6891`
Run duration	`33m 08s`
Commit	`6a078a9beb: fix: [M3-8947] - Remove recently added camelCase rule (#11330)`
Committer	`Purvesh Makode`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`9`
Pending	`2`
Skipped	`0`
Passing	`455`
View all changes introduced in this branch ↗︎