search

linode / manager

Akamai's Cloud Manager is an open-source, single-page application designed as the primary frontend interface for interacting with the Linode API. It is entrusted by hundreds of thousands of customers with the management of their Linode services.
https://cloud.linode.com
Apache License 2.0
700 stars 363 forks source link

test: Fix unit tests depending on `formatPercentage` to reflect latest changes #11334

Closed coliu-akamai closed 4 days ago

coliu-akamai commented 4 days ago

Description 📝

Quick fix to address unit test failures - in #11294, formatPercent now adds an extra space

How to test 🧪

yarn test MetricsDisplay.test.tsx && yarn test statMetrics.test.ts
Author Checklists ## As an Author, to speed up the review process, I considered 🤔 👀 Doing a self review ❔ Our [contribution guidelines](https://github.com/linode/manager/blob/develop/docs/CONTRIBUTING.md) 🤏 Splitting feature into small PRs ➕ Adding a [changeset](https://github.com/linode/manager/blob/develop/docs/CONTRIBUTING.md#writing-a-changeset) 🧪 Providing/improving test coverage 🔐 Removing all sensitive information from the code and PR description 🚩 Using a feature flag to protect the release 👣 Providing comprehensive reproduction steps 📑 Providing or updating our documentation 🕛 Scheduling a pair reviewing session 📱 Providing mobile support ♿ Providing accessibility support
- [x] I have read and considered all applicable items listed above. ## As an Author, before moving this PR from Draft to Open, I confirmed ✅ - [x] All unit tests are passing - [x] TypeScript compilation succeeded without errors - [x] Code passes all linting rules
linode-gh-bot commented 4 days ago

Cloud Manager UI test results

:tada: 455 passing tests on test run #1 ↗︎

:x: Failing:white_check_mark: Passing:arrow_right_hook: Skipped:clock1: Duration
0 Failing455 Passing2 Skipped99m 57s
cypress[bot] commented 4 days ago

Cloud Manager E2E    Run #6888

Run Properties:  status check passed Passed #6888  •  git commit 6abe673b80: test: Fix unit tests depending on formatPercentage to reflect latest changes (#1...
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6888
Run duration 31m 30s
Commit git commit 6abe673b80: test: Fix unit tests depending on formatPercentage to reflect latest changes (#1...
Committer Connie Liu
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 6
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 455
View all changes introduced in this branch ↗︎