linode / manager

Akamai's Cloud Manager is an open-source, single-page application designed as the primary frontend interface for interacting with the Linode API. It is entrusted by hundreds of thousands of customers with the management of their Linode services.
https://cloud.linode.com
Apache License 2.0
688 stars 353 forks source link

getRegion incorrect type #6774

Closed delaneyj closed 3 years ago

delaneyj commented 4 years ago
const region = await getRegion('us-west')
console.log(region)

returns

{
  id: 'us-west',
  country: 'us',
  capabilities: [ 'Linodes', 'NodeBalancers', 'Block Storage', 'Kubernetes' ],
  status: 'ok',
  resolvers: {
    ipv4: '173.230.145.5,173.230.147.5,173.230.155.5,173.255.212.5,173.255.219.5,173.255.241.5,173.255.243.5,173.255.244.5,74.207.241.5,74.207.242.5',
    ipv6: ''
  }
}

which looks like Region but the return is typed as Page<Region> which isn't correct.

johnwcallahan commented 4 years ago

Good catch @delaneyj; I just opened https://github.com/linode/manager/pull/6845 to fix this.