This PR is mostly comments explaining the flow - which can be difficult to follow at times. Also renamed a couple of variables a bit more verbosely which will also hopefully help.
There are also a couple of tidy ups in there - one in Delete which includes an added test case.
Also removed the spurious need for validation of a Bucket CR in a chainsaw test - this was a bit flaky due to errors attempting to reach the webhook.
Best to review this PR one commit at a time.
I have:
[x] Run make reviewable to ensure this PR is ready for review.
[x] Run make ceph-chainsaw to validate these changes against Ceph. This step is not always necessary. However, for changes related to S3 calls it is sensible to validate against an actual Ceph cluster. Localstack is used in our CI Chainsaw suite for convenience and there can be disparity in S3 behaviours betwee it and Ceph. See docs/TESTING.md for information on how to run tests against a Ceph cluster.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.
Description of your changes
This PR is mostly comments explaining the flow - which can be difficult to follow at times. Also renamed a couple of variables a bit more verbosely which will also hopefully help. There are also a couple of tidy ups in there - one in Delete which includes an added test case. Also removed the spurious need for validation of a Bucket CR in a chainsaw test - this was a bit flaky due to errors attempting to reach the webhook. Best to review this PR one commit at a time.
I have:
make reviewableto ensure this PR is ready for review.make ceph-chainsawto validate these changes against Ceph. This step is not always necessary. However, for changes related to S3 calls it is sensible to validate against an actual Ceph cluster. Localstack is used in our CI Chainsaw suite for convenience and there can be disparity in S3 behaviours betwee it and Ceph. Seedocs/TESTING.mdfor information on how to run tests against a Ceph cluster.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
CI +
make ceph-chainsaw