Upgrade build submodule from recently archived upbound/build to crossplane/build.
Updated build submodule now has native support for Chainsaw, so we can remove our own binary download logic.
Temporarily use a patched version of build submodule (nolancon/build@7ad764939006c6e612886880b9a0215f61c63090) which contains the correct Chainsaw download path. This patch has been submitted upstream (https://github.com/crossplane/build/pull/7) and this temporary fix can be reverted once it has been merged.
I have:
[x] Run make reviewable to ensure this PR is ready for review.
[x] Run make ceph-chainsaw to validate these changes against Ceph. This step is not always necessary. However, for changes related to S3 calls it is sensible to validate against an actual Ceph cluster. Localstack is used in our CI Chainsaw suite for convenience and there can be disparity in S3 behaviours betwee it and Ceph. See docs/TESTING.md for information on how to run tests against a Ceph cluster.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.
Description of your changes
upbound/build
tocrossplane/build
.nolancon/build@7ad764939006c6e612886880b9a0215f61c63090)
which contains the correct Chainsaw download path. This patch has been submitted upstream (https://github.com/crossplane/build/pull/7) and this temporary fix can be reverted once it has been merged.I have:
make reviewable
to ensure this PR is ready for review.make ceph-chainsaw
to validate these changes against Ceph. This step is not always necessary. However, for changes related to S3 calls it is sensible to validate against an actual Ceph cluster. Localstack is used in our CI Chainsaw suite for convenience and there can be disparity in S3 behaviours betwee it and Ceph. Seedocs/TESTING.md
for information on how to run tests against a Ceph cluster.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
CI + ceph chainsaw + tested existing make targets