Discovered during testing that the ACL subresource client was only checking for policies and grants in the spec, and not the ACL :man_facepalming:.
Adds a check in the ACL subresource client to ensure and update is made in the event that ACL is specified/updated in the spec. Added a basic test case also.
I have:
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Run make ceph-chainsaw to validate these changes against Ceph. This step is not always necessary. However, for changes related to S3 calls it is sensible to validate against an actual Ceph cluster. Localstack is used in our CI Chainsaw suite for convenience and there can be disparity in S3 behaviours betwee it and Ceph. See docs/TESTING.md for information on how to run tests against a Ceph cluster.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.
Description of your changes
Discovered during testing that the ACL subresource client was only checking for policies and grants in the spec, and not the ACL :man_facepalming:.
Adds a check in the ACL subresource client to ensure and update is made in the event that ACL is specified/updated in the spec. Added a basic test case also. I have:
make reviewableto ensure this PR is ready for review.make ceph-chainsawto validate these changes against Ceph. This step is not always necessary. However, for changes related to S3 calls it is sensible to validate against an actual Ceph cluster. Localstack is used in our CI Chainsaw suite for convenience and there can be disparity in S3 behaviours betwee it and Ceph. Seedocs/TESTING.mdfor information on how to run tests against a Ceph cluster.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested