search

linorobot / linorobot2

Autonomous mobile robots (2WD, 4WD, Mecanum Drive)
Apache License 2.0
436 stars 148 forks source link

Add OAK-D Camera Support #80

Closed mich1342 closed 9 months ago

mich1342 commented 9 months ago

Hi,

I added oak d camera support for linorobot2. Thank you

Best Regards

Michael

grassjelly commented 9 months ago

Hi thanks for the PR, could you replace the OAK-* variables to lowercase without characters, please? I understand that OAK-D driver require it to upper case but could probably be done in the depth.launch.py (see comments above). Thank you!

mich1342 commented 9 months ago

Hi @grassjelly , thank you for your feedback. Have done it. Please review and re-check it. Thank you!

grassjelly commented 9 months ago

thanks @mich1342

grassjelly commented 9 months ago

@mich1342 shall we backport this to galactic and foxy? Does the driver work for those Distros?

mich1342 commented 9 months ago

Hi @grassjelly , it should works for foxy and galactic and foxy. Would be great if we could backport it for both distro

grassjelly commented 9 months ago

@mergify backport foxy galactic humble

mergify[bot] commented 9 months ago

backport foxy galactic humble

✅ Backports have been created

* [#81 Add OAK-D Camera Support (backport #80)](https://github.com/linorobot/linorobot2/pull/81) has been created for branch `foxy` * [#82 Add OAK-D Camera Support (backport #80)](https://github.com/linorobot/linorobot2/pull/82) has been created for branch `galactic` * [#83 Add OAK-D Camera Support (backport #80)](https://github.com/linorobot/linorobot2/pull/83) has been created for branch `humble` but encountered conflicts
grassjelly commented 9 months ago

@mich1342 merged and backported. Thank you!

mich1342 commented 9 months ago

@grassjelly my pleasure. Your repo have helped me a lot during my ROS2 journey.