linorobot / linorobot2

Autonomous mobile robots (2WD, 4WD, Mecanum Drive)
Apache License 2.0
436 stars 148 forks source link

install_linorobot2.bash fails at line 150 #86

Open luapsake opened 9 months ago

luapsake commented 9 months ago

Lines 149, 155, 159 associated with OakD support have a missing space

function install_oakd{
needs to be changed to function install_oakd {

grassjelly commented 9 months ago

fixed here: https://github.com/linorobot/linorobot2/commit/735190729aa77ea8400f187572d6882d1317fb3f . Please let me know if the problem persists

hemsinghb commented 9 months ago

Yes, the Next 2 lines also required space before the flower bracket. total 3 places.

luapsake commented 9 months ago

Hi Juan,Linorobot2 is great!  I cannot find you on linkedin.Paul EkasSAKE RoboticsSokul AutomationOn Sep 20, 2023, at 11:18, Juan Miguel Jimeno @.***> wrote: fixed here: 7351907 . Please let me know if the problem persists

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

luapsake commented 9 months ago

Hi Juan,

I am using linorobot2 as a flexible foundation robot for all the robots we build. I'd like to setup a parallel package that has its own urdfs that instantiate linorobot2 configurations. We will essentially have a fleet of different robots operating all with linorobot2 bases (but with different configurations).

My thought is this. mypackage/ mypackage/robots/ mypackage/robots/robot1 mypackage/robots/robot2 mypackage/robots/robot3/urdf /launch /meshes ...

Do you have an idea or an example that explains how you would do this?

In our implementation, we are not using any of the linobot2 microros implementation. We have all our own hardware and software drivers, etc. That should not be an issue should it?

Thank you for your thoughts.

Is there somewhere else you'd like me to ask these types of questions?

Thank you, Paul

On Thu, Sep 21, 2023 at 2:27 PM @. @.> wrote:

Hi Juan,

Linorobot2 is great! I cannot find you on linkedin.

Paul Ekas SAKE Robotics Sokul Automation

On Sep 20, 2023, at 11:18, Juan Miguel Jimeno @.***> wrote:



fixed here: 7351907 https://github.com/linorobot/linorobot2/commit/735190729aa77ea8400f187572d6882d1317fb3f . Please let me know if the problem persists

— Reply to this email directly, view it on GitHub https://github.com/linorobot/linorobot2/issues/86#issuecomment-1728224476, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP6SQTVTGSFN3Q3UBIOFOBLX3MXQ3ANCNFSM6AAAAAA5AJH5AA . You are receiving this because you authored the thread.Message ID: @.***>