search

linorobot / linorobot2_hardware

Apache License 2.0
94 stars 84 forks source link

Feature/ci pio (#1) #34

Closed atticusrussell closed 11 months ago

atticusrussell commented 1 year ago

A good place to start with CI for PlatformIO builds. Implements #36

atticusrussell commented 1 year ago

@grassjelly what would the procedure be to get this merged?

I would love to continue making more PRs and improvements to this repo, but would want this basic CI system in place to test them.

Some of my ideas for subsequent PRs would be:

  1. Moving the "Galactic" branch to "Rolling" and deprecate branches that don't compile as mentioned in #33.
  2. Expand the CI system to test PlatformIO firmware compilation on a matrix of ROS distros.
  3. Devise a system for backporting to older distros from Rolling and troubleshoot issues with each distro from there, such as #35 that would be relatively simple to solve.
  4. Evaluate existing PRs that aim to add functionality, such as #31, and thoroughly test them. (in the case of that large PR, maybe proposing that each new feature be in a separate PR that can be carefully evaluated).
atticusrussell commented 11 months ago

@grassjelly you mentioned in #37 that you left a comment here and I wanted to let you know that I can't see any comment, but didn't want to leave more unrelated comments in that issue. Not sure what's going wrong.

grassjelly commented 11 months ago

hey @atticusrussell sorry for the late reply and thanks for the PR. The changes looks good to me, however for the sake of other contributors in the future, could you add comments on the steps. Just briefly add notes and what it does.

atticusrussell commented 11 months ago

hey @atticusrussell sorry for the late reply and thanks for the PR. The changes looks good to me, however for the sake of other contributors in the future, could you add comments on the steps. Just briefly add notes and what it does.

@grassjelly Thanks for the feedback. I added comments to the files. Let me know if there's any additional changes you'd like to see.

grassjelly commented 11 months ago

thanks @atticusrussell