linorobot / linorobot2_hardware

Apache License 2.0
92 stars 84 forks source link

ci for each ROS distro #40

Closed atticusrussell closed 10 months ago

atticusrussell commented 11 months ago

Implements issue proposed in #39 as a step on the path to fixing build errors across branches and targeting different ROS distros. Build failures indicate issues with a particular distro.

atticusrussell commented 11 months ago

@grassjelly just wanted to note that the failure of the Galactic checks are a sign the CI works as intended, as the current "galactic" branch does not properly work with ROS Galactic

atticusrussell commented 10 months ago

this PR has been closed until I solve why the nightly CI runs are failing

atticusrussell commented 10 months ago

I solved the CI failures by swapping to using pip to install platformio on the runners and swapped from python 3.9 to 3.10.

atticusrussell commented 10 months ago

@grassjelly this is now ready for merge. It fails CI, but for the correct reasons. (the default linorobot2_hardware branch name should be changed from "galactic" to something like master or main) prior to merging this branch.

The reason the CI fails is the feature that will allow sustainable maintenance of this package for multiple ROS branches: once the default branch is renamed and the 'galactic' branch of this repo has its firmware/platformio.ini updated to use an older version of its dependency (such as in the galactic branch of my fork) its compilation will be properly tested for ROS galactic.

could probably be squash merged.

atticusrussell commented 10 months ago

I plan to clean up this PR so that it only has 2 commits proposed and less chaotic messages