Closed atticusrussell closed 10 months ago
I made an oversight and have not handled the case where ~/.platformio
folder isn't created upon installing it, effecting both this PR and #46. I will fix this and update the branches.
@grassjelly what are your thoughts on names for the default branch? Do you think master, main, or Rolling? Once you change it I can make changes and get this merged (passing CI), and put in a galactic PR.
let me create a rolling branch based on humble
sounds good. I'll go through and make the README badges link to the correct place and double check the CI works correctly with that name (it should - I have it get the default branch)
This PR is the first step in addressing the numerous issues I have seen in the repo with users encountering unexpected errors during firmware updates, such as #37, #35, and others. I outlined my plan to address this in #39, and this PR implements it.
The end result will be a repo that is much easier to safely add new features to, such as support for new boards (like the ESP32 PR), and more friendly to users and maintainers.
NOTE: Before merging this PR, @grassjelly please rename the current default branch, currently named "
galactic
" tomaster
(this is in accordance with the naming ofros_control
and other ROS things I looked at ) or let me know if you'd prefermain
orrolling
and I'll modify the PR. The reasons for this request is two-fold:galactic
"galactic
branch name should be available for backports to ROS2 GalacticIf this renaming is not made, this PR will behave slightly silly upon merge, (but still largely work and still be an improvement):
master
will not be validgalactic
androlling
actions will be run on the current default branch, "galactic
", and thegalactic
action will fail, as the "galactic
" branch'sfirmware/platformio.ini
has a library dependency that has deprecated galacticNOTE 2: There will be companion PRs to the
humble
andfoxy
branches. These should all be merged at a similar time to allow the actions to work for those branches. The foxy PR also contains fixes to current deprecation issues. Upon renaming of the current "galactic
" branch to something else, I will also create a PR for it.