search

linouk23 / NBA-Player-Movements

🏀 Visualization of NBA games from raw SportVU data logs
648 stars 159 forks source link

Bug in y_pos of players and ball #11

Open dimitrisnikolaou10 opened 6 years ago

dimitrisnikolaou10 commented 6 years ago

Hey Kanstantsin,

There is a small bug in the y position of the players and the ball in the animation compared to reality. What we see as the y_pos in the animation is in fact the reflection of the y_pos. You can compare any play you have with highlights on youtube and you will understand what I mean.

A very easy fix would be to adjust the Ball.py and Player.py files as follows:

self.y = ball[3] --> self.y = Constant.Y_MAX - ball[3]

and

self.y = player[3] --> self.y = Constant.Y_MAX - player[3]

obviously, you will need to import the Constant file in both Ball and Player.

Great work otherwise, thanks for posting!

linouk23 commented 5 years ago

@dimitrisnikolaou10 hi, nice catch! Feel free to create a pull request.