search

linq2db / LinqToDB.Identity

ASP.NET Core Identity provider that uses LinqToDB.
https://linq2db.github.io/
MIT License
46 stars 9 forks source link

Upgrade linq2db to version 3.1.1 #22

Closed sfadeev closed 4 years ago

sfadeev commented 4 years ago

After upgrading linq2db to version 3.1.1 in project that used LinqToDB.Identity compiled for linq2db version 2.x getting error due to changed signature of method LinqToDB.DataExtensions.Insert.

System.MissingMethodException: Method not found: 'Int32 LinqToDB.DataExtensions.Insert(LinqToDB.IDataContext, System.__Canon, System.String, System.String, System.String)'.
    at LinqToDB.Identity.Extensions.TryInsertAndSetIdentity[T](IDataContext db, T obj)
   at LinqToDB.Identity.UserStore`7.<>c__DisplayClass48_0.<CreateAsync>b__0()
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.Tasks.Task.<>c.<.cctor>b__274_0(Object obj)
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
--- End of stack trace from previous location where exception was thrown ---
   at LinqToDB.Identity.UserStore`7.CreateAsync(DataConnection db, TUser user, CancellationToken cancellationToken)
   at LinqToDB.Identity.UserStore`7.CreateAsync(TUser user, CancellationToken cancellationToken)
   at Microsoft.AspNetCore.Identity.UserManager`1.CreateAsync(TUser user)
   at Microsoft.AspNetCore.Identity.UserManager`1.CreateAsync(TUser user, String password)

Recompiled for new signature of Insert method of linq2db version 3.1.1, fixed tests.

dnfadmin commented 4 years ago

CLA assistant check
All CLA requirements met.

MaceWindu commented 4 years ago

@ili, @sdanyliv what we should do about this and identity server projects? They definitely don't get enough love from us :)

maybe move them main repo?

sfadeev commented 4 years ago

Good day! Is there any chance to release new nuget packages for LinqToDB.Identity with updated linq2db? Please let me know if you need some help :) Thank you!

MaceWindu commented 4 years ago

@sfadeev we will address this this week. @GonzoSpire you wanted new task :)

MaceWindu commented 4 years ago

@GonzoSpire let's make quick release of 3.0.0 version of nuget to unblock @sfadeev and then cleanup/automate this repo