Fixes to DirectionalGhosts

linqs / pacman

Undergraduate AI assignments disguised as Pac-Man!

https://linqs.github.io/pacman/

Other

11 stars 44 forks source link

Fixes to DirectionalGhosts #59

Closed JEF1056 closed 2 years ago

JEF1056 commented 2 years ago

Fixes two issues:

KeyError when doing dist[a] += float(1 - bestProb) / len(legalActions); the += action cannot be applied to non-existent keys.
dist.normalize() is a dictionary, and does not have a .normalize(). Use probability.normalize() instead

eriq-augustine commented 2 years ago

How's this going? If you want some additional discussion, I am available for a video chat.

JEF1056 commented 2 years ago

Not sure if that fix makes much sense logically because there was no "default value" in the original implementation. As far as I am concerned, that last commit before this acheived everything needed: computation only once, readable, and fixes the original missing key issue.

Feel free to make any more changes as nessasary to merge.

eriq-augustine commented 2 years ago

lgtm Good work!