linqs / psl-examples

Various examples to showcase the functionality of PSL.
61 stars 38 forks source link

squared psl rules #12

Closed dickensc closed 4 years ago

eriq-augustine commented 4 years ago

Why?

dickensc commented 4 years ago

Hyper system used quadratic rules and the examples for lastfm and yelp were linear form. Linear pushes predicates to extreme, i.e. 0 or 1, values, while is this applications we are interested in seeing values between [0, 1].

eriq-augustine commented 4 years ago

I see mostly unsquared rules:

Linear pushes predicates to extreme, i.e. 0 or 1, values, while is this applications we are interested in seeing values between [0, 1].

This is not fully true (both clauses). Also, remember who you are talking to. I understand what squaring a rule does, I was asking you why you wanted to make the change.

dickensc commented 4 years ago

I was using https://github.com/pkouki/iui19 as a reference for the most up to date version of the model. Should we use the recsys2015 version?

eriq-augustine commented 4 years ago

The README of each psl-example describes where the data and model is from. These READMEs cite kouki-recsys15: https://github.com/linqs/psl-examples/blob/master/lastfm/README.md

A big part of the hyper hackathon is to create an updated hyper model. The model can eventually live in psl-examples, but the existing models here are archived (not live) versions of hyper.

The short answer is: kouki-recsys15 should be used, the updated hyper model should be developed elsewhere and eventually moved into psl-examples.

dickensc commented 4 years ago

Okay understood. Sorry if I offended you about my why explanation, I didn't mean to. Thank you for the feedback.