search

linqs / psl

The PSL software from the University of Maryland and the University of California Santa Cruz
http://psl.linqs.org
Apache License 2.0
298 stars 100 forks source link

[CLOSED] Double Step in Voted Perceptron #112

Closed eriq-augustine closed 5 years ago

eriq-augustine commented 5 years ago

Issue by eriq-augustine Thursday Apr 13, 2017 at 19:07 GMT Originally opened as https://github.com/eriq-augustine/psl/issues/65

On line 279 of VotedPerceptron.java, we take a step: weight += currentStep. However, at the end of line 278 there is a hidden weight += currentStep (a semicolon appears before it ending the line and then there is a semicolon after it).

https://github.com/eriq-augustine/psl/blob/develop/psl-core/src/main/java/org/linqs/psl/application/learning/weight/maxlikelihood/VotedPerceptron.java#L278

(Caught by Qifang Zhao)

eriq-augustine commented 5 years ago

Comment by eriq-augustine Friday May 05, 2017 at 21:31 GMT

Fixed in 43ef6102202fd68e198368ed47df0d711fbaeb18.