[CLOSED] pslpython in Jupyter Notebook

linqs / psl

The PSL software from the University of Maryland and the University of California Santa Cruz

http://psl.linqs.org

Apache License 2.0

298 stars 100 forks source link

Closed eriq-augustine closed 5 years ago

eriq-augustine commented 5 years ago

Issue by eriq-augustine Monday Apr 01, 2019 at 04:11 GMT Originally opened as https://github.com/eriq-augustine/psl/issues/202

There seems to be some issues when running under a Jupyter notebook.

Errors/Logs may be getting cut off.
When running inference this error comes up: RuntimeError: This event loop is already running.

Investigate.

eriq-augustine commented 5 years ago

Comment by eriq-augustine Sunday May 12, 2019 at 07:40 GMT

Essentially, you can't run asyncio inside of IPython: https://github.com/jupyter/notebook/issues/3397

So, we have to ditch asyncio.

Pros of removing asyncio:

Cons of removing asyncio:

No longer have the ability to differentiate between stdout and stderr coming from the CLI
Loss of robustness

eriq-augustine commented 5 years ago

Comment by eriq-augustine Sunday May 12, 2019 at 07:42 GMT

Complete in cdcf4cd8776ff21121a1a5111be21d158fb20e22. We now just use subprocess.

Beginning of 3.5 support in: e01cb8a6dfe7a25e4744b3a78e71f06589e285c9.