search

linqs / psl

The PSL software from the University of Maryland and the University of California Santa Cruz
http://psl.linqs.org
Apache License 2.0
298 stars 100 forks source link

Inference Optimization #283

Closed dickensc closed 3 years ago

dickensc commented 4 years ago

Delayed objective calculation in the SGD and DCD reasoners. Saves non-optimizing passes through the data.

Objective change used as stopping criterion is normalized by the number of terms. Future functionality may modify number of ground terms.

Removal of learning rate as an objective term instance variable. Saves memory as the learning rate is common accross potentials and now managed by the reasoner.

Added option for setting the learning schedule for SGD inference. Added option for taking coordinate updates during SGD steps.

Implementation of adagrad and adam in the SGD reasoner. Improves convergence of inference.

eriq-augustine commented 4 years ago

@sriramiscool Can you review this code for correctness? @cfpryor After Sriram is done, can you review this code for style, consistency, and conventions?

eriq-augustine commented 3 years ago

LGTM! You did it, great job!