search

linqueta / rails-healthcheck

A simple way to configure a healthcheck route for a Rails application
MIT License
136 stars 10 forks source link

Replace dependency on `rails` with specific sub-dependencies #47

Closed nickcampbell18 closed 3 years ago

nickcampbell18 commented 3 years ago

Following the mime gem incident I've been reviewing which of the gems we use depend on the rails meta-gem rather than the specific dependencies. At the moment, by requiring rails, if I use this gem for a small API-only application I will be forced to pull in features like actioncable, activestorage, which expands my dependency surface area and increases the risk of a dependency incident like this.

Would you be open to a pull request to only require the sub-dependencies needed for this gem? At a glance I think it might just be railties and actionpack (for ActionController) that you need.

Thanks! (oh also, this is a great gem thanks for maintaining it 🙏 )

linqueta commented 3 years ago

Hey man, I really think it makes a lot a sense.

Could you open a pull request with it? I have to change tests to use github actions and we can merge it this week.

Regards!

nickcampbell18 commented 3 years ago

:+1: https://github.com/linqueta/rails-healthcheck/pull/48