search

linrongbin16 / fzfx.nvim

A Neovim fuzzy finder that updates on every keystroke.
https://linrongbin16.github.io/fzfx.nvim/
MIT License
122 stars 5 forks source link

Unify hotkeys in `FzfxFileExplorer` #506

Closed savchenko closed 8 months ago

savchenko commented 9 months ago

I propose to replace alt with ctrl here:

https://github.com/linrongbin16/fzfx.nvim/blob/e72c48659b0b856795b885ad9e84a32dc42ec11c/lua/fzfx/cfg/file_explorer.lua#L287-L297

This will allow unified Ctrl+HJKL in the file explorer.

Tested locally, works as expected.

linrongbin16 commented 8 months ago

hi @savchenko , with a 2nd thought, I think your suggestion is actually good.

Actually I had set the cd and upper key to ctrl-l and ctrl-h. But when I test it in all my 3 OS: macOS/ubuntu/Windows 10, with 3 main stream terminal: iterm2, gnome-terminal and Windows Terminal. I found ctrl-l and ctrl-h are not working in some of the OS and terminals. So I set them to alt keys.

But now I think, if the keys not working, just let users to set them to other keys. ctrl-l and ctrl-h really look more Vim ways.

this is updated in https://github.com/linrongbin16/fzfx.nvim/pull/510, please pull latest main branch and try.

savchenko commented 8 months ago

Works as expected now, thank you!

Tested using nVim v0.9.4 and foot terminal.