search

linrongbin16 / fzfx.nvim

A Neovim fuzzy finder that updates on every keystroke.
https://linrongbin16.github.io/fzfx.nvim/
MIT License
122 stars 5 forks source link

Invalid buffers list after change session #528

Closed damanis closed 8 months ago

damanis commented 8 months ago

After load another session FzfxBuffers shows only one buffer. For example, Telescope buffers show all session buffers. Used session maganer: Possession

linrongbin16 commented 8 months ago

hi @damanis , it's late in night (in my timezone), I will look into it later.

damanis commented 8 months ago

@linrongbin16 , I just opened issue. Maybe I'll se it on weekend.

linrongbin16 commented 8 months ago

hi @damanis, if this issue didn't happen before, just show up in recent days, then it could be introduced in #526.

To prove this thought, could you help try the previous tag 'v4.1.2'? it's the latest version before that PR.

damanis commented 8 months ago

@linrongbin16 Confirm, tagv4.1.2 works properly, show all buffers after load new session.

linrongbin16 commented 8 months ago

hi @damanis , then it must be the PR's change, I will create one more data source, one is the old one (include the unload buffers), one is the PR's behavior (exclude the unload buffers).

and BTW, I add the notification in README install section, recommend users to specify version/tag when install this plugin, since I'm going to merge variants as sub commands to reduce too many created user commands, which is going to be a break change, which could force user to re-configure the plugin.

But I think it's a much better design for this project, and I want to always use the best design to do thing in correct way.

damanis commented 8 months ago

@linrongbin16

one is the old one (include the unload buffers), one is the PR's behavior (exclude the unload buffers).

If I understand correctly, you will create two tags with different behavior? Why just not get buffers list in every call of FzfxBuffers?

damanis commented 8 months ago

recommend users to specify version/tag when install this plugin

But in this case the features added after the tag will be unavailable.

linrongbin16 commented 8 months ago

recommend users to specify version/tag when install this plugin

But in this case the features added after the tag will be unavailable.

I will upgrade the major version number (for example v4 - v5) when we have a break change.

only lazy.nvim support the semver, you can use v4.* to accept following updates in v4. and upgrade to v5 when you want.

damanis commented 8 months ago

4.1.2 has no buffers problem, 4.1.3 has one. If select 4.1.2, so all changes in 4.1.{4-*} will be unavailable, isn't it?

linrongbin16 commented 8 months ago

4.1.2 has no buffers problem, 4.1.3 has one. If select 4.1.2, so all changes in 4.1.{4-*} will be unavailable, isn't it?

I think it's yes.

damanis commented 8 months ago

So, again, why just not get buffers list in every call of FzfxBuffers? It will solve both problem. Or, maybe, nvim provides some additional event (fzf-lua and telescope buffers show proper list).

linrongbin16 commented 8 months ago

hi @damanis, the fix pr is merged, please pull and try again.

damanis commented 8 months ago

@linrongbin16 Confirmed, fixed. Happy New Year!

linrongbin16 commented 8 months ago

hi @savchenko, sorry previous #522 #526 is been reverted in #536, but I will create another variant buffers.

savchenko commented 8 months ago

@linrongbin16 , all good, I might need to find a way to list those correctly in my function. I remember there was some problem with it...