linrongbin16 / fzfx.nvim

A Neovim fuzzy finder that updates on every keystroke.
https://linrongbin16.github.io/fzfx.nvim/
MIT License
122 stars 5 forks source link

perf(sub commands)!: merge variants into sub commands #534

Closed linrongbin16 closed 8 months ago

linrongbin16 commented 8 months ago

Regresion test

Platforms

Tasks

linrongbin16 commented 8 months ago

This is first from an issue or discussion, reporter want to reduce too many created user commands.

I agree with reporter's idea, telescope and fzf-lua they also register only one user command, but adding a lot of sub commands.

For now I merge multiple variants into the sub commands, so:

Will become only 1 command FzfxFiles with below sub commands:

This improvement also introduce a break change, so we're going to upgrade to v5.x.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (a0dd9fa) 81.15% compared to head (d8f2358) 80.49%.

Files Patch % Lines
lua/fzfx/detail/general.lua 39.21% 31 Missing :warning:
lua/fzfx/cfg/live_grep.lua 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #534 +/- ## ========================================== - Coverage 81.15% 80.49% -0.66% ========================================== Files 45 45 Lines 4675 4476 -199 ========================================== - Hits 3794 3603 -191 + Misses 881 873 -8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.