linrongbin16 / fzfx.nvim

A Neovim fuzzy finder that updates on every keystroke.
https://linrongbin16.github.io/fzfx.nvim/
MIT License
114 stars 5 forks source link

feat(marks): add 'FzfxMarks' #627

Closed linrongbin16 closed 5 months ago

linrongbin16 commented 5 months ago

Related: #523 .

Regresion test

Platforms

Tasks

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 94.09449% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 79.42%. Comparing base (ee15b71) to head (863a43d).

Files Patch % Lines
lua/fzfx/cfg/vim_marks.lua 96.95% 5 Missing :warning:
lua/fzfx/helper/previewer_labels.lua 58.33% 5 Missing :warning:
lua/fzfx/helper/actions.lua 95.34% 2 Missing :warning:
lua/fzfx/helper/parsers.lua 92.00% 2 Missing :warning:
lua/fzfx/cfg/vim_commands.lua 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #627 +/- ## ========================================== + Coverage 78.81% 79.42% +0.61% ========================================== Files 52 53 +1 Lines 5937 6178 +241 ========================================== + Hits 4679 4907 +228 - Misses 1258 1271 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

savchenko commented 5 months ago

Testing this locally, it does seem to skip most recently created lowercase marks.

For example, regular :marks

image

And FzfxMarks

image

Further, I think what is needed to help a user is:

  1. List of marks
  2. Preview window

Column, line number and anything else is secondary.

linrongbin16 commented 5 months ago

hi @savchenko , thanks to your feedback.

  1. I will take a look on the "lowercase marks missing" issue.
  2. For the line numbers & columns, I have to say they're mandatory for previewing, because if we don't have it, we cannot find a file location to preview the content.

update: the "lowercase marks" missing issue is fixed.