search

linsalrob / PhiSpy

Prediction of prophages from bacterial genomes
MIT License
70 stars 21 forks source link

Fixing phmms data use condition #39

Closed pdec closed 4 years ago

pdec commented 4 years ago

Currently the below condition is always False, https://github.com/linsalrob/PhiSpy/blob/2500fbda01fc6f36e95c69ef39c5cf3be22215b1/PhiSpyModules/classification.py#L41-L43 and phmms signal columns are considered even if not used. There was also a mistake in L43 where test_data had train_data assigned.

This should be:

 if not kwargs['phmms']: 
     train_data = np.delete(train_data, 5, 1) 
     test_data = np.delete(test_data, 5, 1)