search

linstula / ember-cli-bootstrap

ember-cli addon for Twitter Bootstrap
37 stars 20 forks source link

Collapsible panels #20

Open samselikoff opened 9 years ago

samselikoff commented 9 years ago

Collapsible panels are part of bootstrap-for-ember but I don't believe they work with ember-cli-bootstrap because it requires the bootstrap JS. What do you think? Should that piece of bootstrap js be included by default? Or, should we add a section of the readme listing out which pieces of bootstrap-for-ember need the Bootstrap JS?

linstula commented 9 years ago

Because we're defaulting to importing all the components, we should be consistent and import bootstrap.js so all the components work out of the box. We should also list which components require bootstrap.js so people can easily identify if they can opt out of importing bootstrap.js without causing breakages if they are not using the listed components. On Oct 8, 2014 12:19 PM, "Sam Selikoff" notifications@github.com wrote:

Collapsible panels are part of bootstrap-for-ember but I don't believe they work with ember-cli-bootstrap because it requires the bootstrap JS. What do you think? Should that piece of bootstrap js be included by default? Or, should we add a section of the readme listing out which pieces of bootstrap-for-ember need the Bootstrap JS?

— Reply to this email directly or view it on GitHub https://github.com/dockyard/ember-cli-bootstrap/issues/20.

linstula commented 9 years ago

After thinking about this, I think it actually makes more sense not import the Bootstrap JS by default. This appears to be an isolated issue with the bs-panel component: https://github.com/ember-addons/bootstrap-for-ember/issues/137. I'll leave this issue open in the mean time so it can be referenced by others.