search

linstula / ember-cli-bootstrap

ember-cli addon for Twitter Bootstrap
37 stars 20 forks source link

Add Glyphicon Fonts to output directory #6

Closed drewcovi closed 10 years ago

drewcovi commented 10 years ago

This should resolve any missing fonts in the output directory.

drewcovi commented 10 years ago

this should resolve dockyard/ember-cli-bootstrap#1

drewcovi commented 10 years ago

@linstula let me know if there's anything more I can include to make this work a little better, this has been a huge help. thanks!

linstula commented 10 years ago

@drewcovi sorry for not getting back to you on this PR sooner. This is a good direction but has become a bit too divergent from master so will be closing this PR.

I noticed that part of the PR was importing the javascript from bootstrap. My goal with this project is to leverage the work from https://github.com/ember-addons/bootstrap-for-ember to implement bootstrap components in a more 'ember' way. What functionality are you trying to get that isn't part of bootstrap-for-ember?

drewcovi commented 10 years ago

I've been using various items such as the collapse functionality, and other third party bootstrap plugins that rely on bootstrap.js.

I definitely enjoy the component approach, but there is far more to the framework that is lost without actually leveraging bootstrap.js

drewcovi commented 10 years ago

It just seems a little redundant to pull this in and still have to import bootstrap.js through brocfile imports... Although I'm open to alternatives.

drewcovi commented 10 years ago

@linstula so if folks are looking to use the huge library of bootstrap plugins, is the recommended course to just include it through brocfile imports still?

linstula commented 10 years ago

@drewcovi I think the way I'd like to go with this is to allow users to pass in an option in the Brocfile that, when true, will import bootstrap.js. In the future importing bootstrap.js might become the default and users can opt out if they don't need it but I'd like to start with this. Feel free to send in a PR or I'll try and get to this later on in the week.