linsyking / CanvasHelper2

New generation of Canvas Helper.
MIT License
13 stars 5 forks source link

Feat/pyinstaller #19

Closed zzjc1234 closed 5 months ago

zzjc1234 commented 10 months ago

This pr modified canvas_app s.t. the code can be packed with pyinstaller

linsyking commented 10 months ago

Have you tested whether pyinstaller can work on this?

zzjc1234 commented 10 months ago

Yes, the exe works well. I disablesd the output in console, I think users may not need it.

zzjc1234 commented 10 months ago

The updator may have some unknown problem, but the updator.py should be modified anyway. Maybe I will fix it in another pr.

linsyking commented 10 months ago

For executables the old updater doesn't work because it is based on git

linsyking commented 10 months ago

Maybe we can just remove git update logic when building for executables.

zzjc1234 commented 10 months ago

It seems that I didn't solve the dependency well, currently the exe only works under the dir with canvas_mgr.py and etc. I will try to fix it.

linsyking commented 10 months ago

Also we need to migrate some arguments from uvicorn to the executables, eg. the port and base_url

linsyking commented 10 months ago

I think we can remove the updater support. It is not very helpful and needs git dependency.

linsyking commented 10 months ago

do not merge until everything is set

linsyking commented 10 months ago

Please fix the build error.

linsyking commented 10 months ago

I think we should first merge it to the dev branch otherwise current users will be affected