linterjs / core

Lint all the things... with one command
MIT License
4 stars 0 forks source link

Return an array of promises from lint #10

Closed zimme closed 6 years ago

zimme commented 6 years ago

Add an option to return an array of Promise<LinterAdapterLintOutput>.

I'm not sure this makes sense, but I'm thinking that the consumer of the api could have a use case for wanting to wait for individual linter results instead of having to wait for all results to resolve before being able to access them.

@azz Thoughts?

zimme commented 6 years ago

I'm thinking that just returning an array of promises for each lint output is the best thing and then it's up to the consumers to use Promise.all if the need to wait for all output before using it.

codecov-io commented 6 years ago

Codecov Report

Merging #10 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #10   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          38     38           
  Branches        5      5           
=====================================
  Hits           38     38
Impacted Files Coverage Δ
src/lint.ts 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2caec9e...f3c0b50. Read the comment docs.

azz commented 6 years ago

Codecov and coveralls?

zimme commented 6 years ago

Testing them out, also setup codeclimate's test coverage. :smile:

I've used all of them in different project, but I haven't set them up so I don't really know which one I feel is most useful. Thinking I'll have all running for a few weeks and then we keep the one we feel is the best fit.

azz commented 6 years ago

Personal preference is codecov with comments disabled. Gives you patch and project diffs as build status. All you really need.

zimme commented 6 years ago

Yeah, I thought about turing the comments off actually. Also, I'm currently liking codecov a bit more then the rest.