search

lintool / warcbase

Warcbase is an open-source platform for managing analyzing web archives
http://warcbase.org/
161 stars 47 forks source link

Do we still need ExtractLinksAndText? #176

Closed lintool closed 8 years ago

lintool commented 8 years ago

Do we still need the Scala UDF ExtractLinksAndText? It seems like everything we need is already supported by the ExtractLinks UDF.

aliceranzhou commented 8 years ago

No, we do not. Shall I remove it?

On Tue, Nov 24, 2015 at 9:01 PM Jimmy Lin notifications@github.com wrote:

Do we still need the Scala UDF ExtractLinksAndText? It seems like everything we need is already supported by the ExtractLinks UDF.

— Reply to this email directly or view it on GitHub https://github.com/lintool/warcbase/issues/176.

lintool commented 8 years ago

It's okay, I'll do it as part of my cleanup pass...

aliceranzhou commented 8 years ago

Okay, thank you Prof. Jimmy!

On Tue, Nov 24, 2015 at 9:23 PM Jimmy Lin notifications@github.com wrote:

It's okay, I'll do it as part of my cleanup pass...

— Reply to this email directly or view it on GitHub https://github.com/lintool/warcbase/issues/176#issuecomment-159467177.

lintool commented 8 years ago

Fixed commit 26d2ef518fb33632dcfd6a0bcfbd00ff7731d232