search

linuslundahl / good-old-gallery

Good Old Gallery is a WordPress plugin that helps you upload image galleries that can be used on more than one page/post, it utilizes the built in gallery functionality in WP. Other features include built in Flexslider support and Widgets.
http://unwi.se/good-old-gallery
0 stars 1 forks source link

Is the final goal a Responsive Slider? #5

Open markimark opened 12 years ago

markimark commented 12 years ago

I just would like to know if the final goal of this new version is to create a responsive slider? I ask this because I was working on it all day long and it seems that there is no way to make the slider work responsive in Firefox 9.0.1 or IE9 at all. I managed to make it work in Chrome but unfortunately, in today's world, this would not be enough.

Can you tell me if the slider suppose to work, at this stage, in Firefox and IE the same way as it does in Chrome?

I really hope that this is the final goal because Responsive Design is the talk of the town. There are many slider plugin's out there for WP but very soon, they all will become useless. What we need is a good working flexslider or the wmu slider plugin. Fingers crossed....

linuslundahl commented 12 years ago

Flexslider (http://flex.madebymufffin.com/) is a jQuery Slider plugin that is NOT written by me, it is responsive by default. If you have issues with it not being responsive, there's most likely some css setting a fixed width on your gallery. I can't help you with this, all I can do is provide a plugin that gives you the tools to make galleries, and try to make it as easy as possible to implement it.

What you can do is turn off themes and comment out all css applied by good-old-gallery.css. This will give you a completely bare gallery css, which means any css applied to the gallery comes from your theme.

An like I said, Flexslider support is still experimental, it should of course be responsive. But I can't guarantee it with all themes out there.

markimark commented 12 years ago

Actually I know what flexslider is. I develope themes (not WP ones) and it is easy to use the slider. It just does not work in combination with WP and I thought that your plugin can take care of this. There is no fixed width anywhere around the gallery that is generated by your plugin. It works in chrome but not firefox or IE. The question is, did you ever include your plugin in any WP theme and then tested it on firefox or IE?

I really would like to know that.

On Thu, Feb 16, 2012 at 7:07 PM, Linus Lundahl < reply@reply.github.com

wrote:

Flexslider (http://flex.madebymufffin.com/) is a jQuery Slider plugin that is NOT written by me, it is responsive by default. If you have issues with it not being responsive, there's most likely some css setting a fixed width on your gallery. I can't help you with this, all I can do is provide a plugin that gives you the tools to make galleries, and try to make it as easy as possible to implement it.

What you can do is turn off themes and comment out all css applied by good-old-gallery.css. This will give you a completely bare gallery css, which means any css applied to the gallery comes from your theme.

An like I said, Flexslider support is still experimental, it should of course be responsive. But I can't guarantee it with all themes out there.

Reply to this email directly or view it on GitHub:

https://github.com/linuslundahl/good-old-gallery/issues/5#issuecomment-4005952

markimark commented 12 years ago

I did what you said. Disabled all Slider Themes, renamed the gog.css to gog.css.bak and all is working beautifully now. The responsive slider is now showing up in all 3 browsers and is resizing perfectly when changing the browser resolution. What does that tell you? What can I do to use your plugin without to disable almost half of it?

Thanks for any help.

linuslundahl commented 12 years ago

The included theme was originally written for jQuery Cycle, which is not responsive. I just quickly ported it to work with Flexslider. I've had a look at it and tried to fix the issues, it works fine here with the Twenty Eleven theme. Download it and try it.

markimark commented 12 years ago

I will try. I also created my own theme and it is now working perfectly. I mean, that was quite some issue, right? I would love to stay in touch during the development with you. I love your approach most from all others and as I said, the only slider needed for WP right now, is the Flexslider.

Cheers from Berlin

On Thu, Feb 16, 2012 at 8:29 PM, Linus Lundahl < reply@reply.github.com

wrote:

The included theme was originally written for jQuery Cycle, which is not responsive. I just quickly ported it to work with Flexslider. I've had a look at it and tried to fix the issues, it works fine here with the Twenty Eleven theme. Download it and try it.

Reply to this email directly or view it on GitHub:

https://github.com/linuslundahl/good-old-gallery/issues/5#issuecomment-4007545

markimark commented 12 years ago

OK. In general your modifications to the 2 files make it work now in all 3 browsers but there is still an issue with the "next" and "prev" buttons. Regardless of your settings, they never disappear completely. They are always in front of the images. Only difference between disable or enable is, within the image or outside of the image but always visible. Also I don´t know what the wanted hover behavior is. In IE it turns from light grey to dark grey but in Firefox or Chrome the icon is actually moving when hovering. The light version of the arrow is moving out of the visible area and the dark arrow is moving in. Maybe you can have a look at it. In the meantime I can use my theme.

Thanks for your help.

linuslundahl commented 12 years ago

I had a look at it and it's fixed now, you need to re-save your settings page though.

markimark commented 12 years ago

What does that mean? It was always OK but I have to save my settings? I did, several times but it does not change anything. Or do you mean you have fixed it NOW and I have to download it again and then save my settings?

On Thu, Feb 16, 2012 at 10:18 PM, Linus Lundahl < reply@reply.github.com

wrote:

I had a look at it and it's fixed now, you need to re-save your settings page though.

Reply to this email directly or view it on GitHub:

https://github.com/linuslundahl/good-old-gallery/issues/5#issuecomment-4009640

markimark commented 12 years ago

This is how it looks with all nav elements disabled in settings. Still all visible.... http://cl.ly/192X3P3p3H1c2e2U3J1h

linuslundahl commented 12 years ago

I fixed it, meaning I updated the code, meaning you need to update the plugin and then re-save the settings. If you're using widgets you need to re-save their settings too.

markimark commented 12 years ago

Thank you for being open minded for the issue I brought up. Now it is working quite nice.

Have a nice day.

Mark

On Fri, Feb 17, 2012 at 8:13 AM, Linus Lundahl < reply@reply.github.com

wrote:

I fixed it, meaning I updated the code, meaning you need to update the plugin and then re-save the settings. If you're using widgets you need to re-save their settings too.

Reply to this email directly or view it on GitHub:

https://github.com/linuslundahl/good-old-gallery/issues/5#issuecomment-4016216

markimark commented 12 years ago

I have to bother you again, sorry. Did you really test your plugin on his responsive capabilities after adding flexslider support? I mean, adding a gallery and then resizing the browser to different resolutions? I ask you this because I think it would not work out of the box. For me, it only works if I use jQuery to remove the width and heights from the images I use for the gallery. WP is always adding those to every picture and that does not work with flexslider. Do I miss something here?

markimark commented 12 years ago

The above was a serious question. Can I expect any response on that. Thanks for telling me.

linuslundahl commented 12 years ago

Responsive galleries are working just fine when I test in Safari, Chrome and Firefox. I'm testing with the Twenty Eleven theme. I can't help you more than that.

markimark commented 12 years ago

Actually I am fine, all works pretty here but only after I added the jquery function to delete the given height and width. Without, it is not resizing. Strange that it does work on your site without deleting the dimensions that are given by WP on default for every image.

On Mon, Feb 27, 2012 at 6:39 PM, Linus Lundahl < reply@reply.github.com

wrote:

Responsive galleries are working just fine when I test in Safari, Chrome and Firefox. I'm testing with the Twenty Eleven theme. I can't help you more than that.

Reply to this email directly or view it on GitHub:

https://github.com/linuslundahl/good-old-gallery/issues/5#issuecomment-4198738