Closed Luflosi closed 3 years ago
I decided to change the =
assignment operator to ?=
so that DESTDIR
can be set via an environment variable.
If you have a minute, would you mind adding the hacktoberfest-accepted
label to this and the other two PRs please?
On Sat, Oct 09, 2021 at 10:52:02AM -0700, Luflosi wrote:
If you have a minute, would you mind adding the
hacktoberfest-accepted
label to this and the other two PRs please?
What does that label mean?
See https://hacktoberfest.digitalocean.com/resources/participation.
Without the hacktoberfest-accepted
label, PRs are ignored for the hacktoberfest. Two years ago, the system was not opt in so that everyone could submit PRs to any repo and it would automatically count when merged but there was a huge spam problem, where lots of people would open a lot of very low quality PRs. Because of that, the system is now opt-in.
Thank you.
Changing the destination directory is commonly needed when packaging for distribution. This commit makes it easy to do so without having to change
BINDIR
andMANDIR
. This patch is almost identical to https://aur.archlinux.org/cgit/aur.git/tree/destdir.patch?h=apfsprogs-git&id=c3da4488345d720776050f6a562e718d238589fb from the AUR. It will also make the declaration in Nixpkgs sightly simpler and as a side-effect fix a mistake I accidentally copied from the AUR, copying the man page to the wrong location: https://github.com/NixOS/nixpkgs/blob/40f95ae12ac630b76e8f4aa2d378fd2f2a959ff5/pkgs/tools/filesystems/apfsprogs/default.nix#L26-L27