search

linux-apfs / linux-apfs-rw

APFS module for linux, with experimental write support
GNU General Public License v2.0
510 stars 34 forks source link

improve check for encryption, as described in issue #11 #31

Closed Patronics closed 1 year ago

Patronics commented 1 year ago

This should detect encrypted APFS containers from the superblock metadata, not limited to rolling encryption as the existing feature flag check was.

eafer commented 1 year ago

Hi, sorry for the delay. The reason I've never added a check like this is because the so-called encrypted volumes I have to work with (from ios disk images, mostly) are perfectly readable anyway. I've never looked into how encryption is supposed to work, but banning the mount entirely would be a problem for me. I think the best thing to do is just warn the user that the volume is encrypted and may not be readable.

eafer commented 1 year ago

I just pushed this patch to development under your name, but I made it just a warning message, it still mounts. Let me know if you have any objection.

Patronics commented 1 year ago

I just pushed this patch to development under your name, but I made it just a warning message, it still mounts. Let me know if you have any objection.

Good idea, that should be perfect, thanks!