linux-apfs / linux-apfs-rw

APFS module for linux, with experimental write support
GNU General Public License v2.0
510 stars 34 forks source link

Build fails with 6.10 #73

Closed ymatsiuk closed 1 month ago

ymatsiuk commented 1 month ago

The error is:

/build/source/super.c: In function 'apfs_sb_set_blocksize':
/build/source/super.c:60:39: error: passing argument 1 of 'set_blocksize' from incompatible pointer type [-Werror=incompatible-pointer-types]
   60 |         if (set_blocksize(APFS_NXI(sb)->nx_bdev, size))
      |                           ~~~~~~~~~~~~^~~~~~~~~
      |                                       |
      |                                       struct block_device *
In file included from /build/source/super.c:7:
/nix/store/hlhp0pprnyq96npl2k1b5z9iy2xc4c9q-linux-6.10-dev/lib/modules/6.10.0/source/include/linux/blkdev.h:1495:32: note: expected 'struct file *' but argument is of type 'struct block_device *'
 1495 | int set_blocksize(struct file *file, int size);
      |                   ~~~~~~~~~~~~~^~~~

Most probably related to this & this..

eafer commented 1 month ago

Those errors should have already been fixed here: https://github.com/linux-apfs/linux-apfs-rw/commit/071cdacc32e15c6121b925c130ff6b509dfc5693. Are you building the latest tag (0.3.10)?

Luflosi commented 1 month ago

This issue can be closed. NixOS still ships 0.3.9 because my PR updating it to 0.3.10 hasn't been merged yet: https://github.com/NixOS/nixpkgs/pull/327490.

ymatsiuk commented 1 month ago

OMG, apologies for this, I should've checked the code first :blush:

eafer commented 1 month ago

No problem.