linux-audit / audit-kernel

GitHub mirror of the Linux Kernel's audit repository
https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git
Other
138 stars 36 forks source link

BUG: audit_context isn't needed when !CONFIG_AUDITSYSCALL #105

Closed rgbriggs closed 5 years ago

rgbriggs commented 5 years ago

audit_context is not used in struct task_struct when AUDITSYSCALL is disabled. audit_alloc() is stubbed in that case to return 0. audit_context() returns NULL.

The fact that audit_context is still present in struct task_struct appears to be an oversight in the two patches:

pcmoore commented 5 years ago

@rgb assigning this to you because I'm assuming you want this, if not just let me know.

rgbriggs commented 5 years ago

Post v1 https://www.redhat.com/archives/linux-audit/2019-January/msg00079.html https://lkml.org/lkml/2019/1/22/1022

rgbriggs commented 5 years ago

v1.1/2 Staged in audit/next v5.0-rc1: 05c7a9cb2727 ("audit: clean up AUDITSYSCALL prototypes and stubs")

rgbriggs commented 5 years ago

Post v2 https://www.redhat.com/archives/linux-audit/2019-January/msg00118.html https://lkml.org/lkml/2019/1/28/1779

rgbriggs commented 5 years ago

v3 (was v1.2/2) staged in audit/next v5.0-rc1: 5f3d544f1671 ('audit: remove auditcontext when CONFIG AUDIT and not AUDITSYSCALL")

rgbriggs commented 5 years ago

2019-01-05: Post v3 supplemental: ("audit: hide auditsc_get_stamp and audit_serial prototypes") https://www.redhat.com/archives/linux-audit/2019-February/msg00015.html

rgbriggs commented 5 years ago

Staged in audit/next v5.0-rc1: cd108b5c51db ("audit: hide auditsc_get_stamp and audit_serial prototypes")